Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

These commits modify compiler targets.
(See the Target Tier Policy.)

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

r? jieyouxu

cc @eddyb Hello, tagging you for domain expertise if you want to chime in.

Thanks for the PR, @Flakebi. I'm going to request that you open a MCP at https://github.com/rust-lang/compiler-team/issues/ to gauge team consensus for adding this target, primarily to give compiler team members some opportunity to ask clarifying questions and register possible concerns, since:

• Adding this target requires modifying codegen_llvm in a non-trivial way (emitting at times
  addrspacecast instead of bitcast). In particular, as you stated, this target has a
  non-conventional addrspace usage model that I believe we don't quite observe in other existing
  targets:

  The amdgpu backend makes heavy use of different address spaces. This leads to situations,
  where a pointer in one addrspace needs to be casted to a pointer in a different addrspace.
  bitcast is invalid for this case, addrspacecast needs to be used.

• This requires modifying the LLVM build to also include the AMDGPU backend.

• This target seems to be intended for many different CPUs of varying hardware generation, but the
  present target definition defaults to gfx900.

Note that usually adding more "conventional" Tier 3 targets do not need to go through the MCP process, but this target looks not so conventional.

@rustbot author

Thank you for the quick review!

I opened an MCP here: rust-lang/compiler-team#823

cc @ZuseZ4

☔ The latest upstream changes (presumably #134822) made this pull request unmergeable. Please resolve the merge conflicts.

A job failed! Check out the build log: (web) (plain)

dist-loongarch64-linux
dist-loongarch64-muls
dist-powerpc64-linux
##[endgroup]
INFO:root:Job type: TryRunType(custom_jobs=['dist-loongarch64-linux', 'dist-loongarch64-muls', 'dist-powerpc64-linux'])
  File "/home/runner/work/rust/rust/src/ci/github-actions/ci.py", line 314, in <module>
    calculate_job_matrix(data)
  File "/home/runner/work/rust/rust/src/ci/github-actions/ci.py", line 266, in calculate_job_matrix
  File "/home/runner/work/rust/rust/src/ci/github-actions/ci.py", line 266, in calculate_job_matrix
    jobs = calculate_jobs(run_type, job_data)
  File "/home/runner/work/rust/rust/src/ci/github-actions/ci.py", line 153, in calculate_jobs
    raise Exception(
    raise Exception(
Exception: Custom job(s) `['dist-loongarch64-muls']` not found in auto jobs
##[error]Process completed with exit code 1.

ah its called musl and not muls :)
@bors try

⌛ Trying commit 56795fb with merge ad8d586...

☀️ Try build successful - checks-actions
Build commit: ad8d586 (ad8d58687ff5e1b7935c4b25be4e251d15443948)

@bors r=workingjubilee

💡 This pull request was already approved, no need to approve it again.

• There's another pull request that is currently being tested, blocking this pull request: Always set the deployment target when building std #133092

📌 Commit 56795fb has been approved by workingjubilee

It is now in the queue for this repository.

⌛ Testing commit 56795fb with merge c03c38d...

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing c03c38d to master...

Finished benchmarking commit (c03c38d): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

Max RSS (memory usage)

Cycles

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.876s -> 781.62s (0.48%)
Artifact size: 329.17 MiB -> 348.30 MiB (5.81%)

The syn regression is noise, the rest is possibly caused by the fact that the shipped LLVM is now 19 MiB larger due to the inclusion of the AMDGPU target.

I'm not sure that size is really a driver for more instruction counts, but it does look like the mere possibility of cross-compiling to AMDGPU is enabling more passes/logic(?) even if presumably those don't do anything on x86. Maybe an optimization opportunity for LLVM/clang? It might be unavoidable with the architecture LLVM has today though.

Sampling a few cachegrind diffs:

helloworld:

--------------------------------------------------------------------------------
-- File:function summary
--------------------------------------------------------------------------------
  Ir______  file:function

<  575,695  ???:
   844,600    llvm::PassRegistry::enumerateWith(llvm::PassRegistrationListener*)
  -782,786    llvm::PassRegistry::enumerateWith(llvm::PassRegistrationListener*) [clone .warm]
   -69,691    llvm::FPPassManager::runOnFunction(llvm::Function&)
    60,129    llvm::MVT::getScalableVectorVT(llvm::MVT, unsigned int)
    54,986    ecache_evict
   -49,525    llvm::SelectionDAGISel::CodeGenAndEmitDAG()
   -41,251    std::back_insert_iterator<llvm::SmallVector<llvm::BasicBlock*, 8u> > std::copy<llvm::po_iterator<llvm::BasicBlock*, llvm::SmallPtrSet<llvm::BasicBlock*, 8u>, false, ll>
    40,624    llvm::StringMapImpl::RehashTable(unsigned int)
    39,256    llvm::StringMapImpl::LookupBucketFor(llvm::StringRef, unsigned int)
    38,978    edata_cache_get
    38,420    llvm::InstCombinerImpl::visitCallBase(llvm::CallBase&)
    37,509    llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>::invalidate(llvm::LazyCallGraph::SCC&, llvm::PreservedAnalyses const&)
    36,129    llvm::SelectionDAG::Legalize()
   -33,750    llvm::PassRegistry::registerPass(llvm::PassInfo const&, bool)
   -33,501    llvm::InstCombinerImpl::visitCallInst(llvm::CallInst&)
   -31,525    tcache_bin_flush_small
    31,343    llvm::PMTopLevelManager::findAnalysisPassInfo(void const*) const
    30,580    eset_remove

clap:

--------------------------------------------------------------------------------
-- File:function summary
--------------------------------------------------------------------------------
  Ir__________  file:function

<  209,305,246  ???:
  -230,519,105    llvm::computeKnownBitsFromContext(llvm::Value const*, llvm::KnownBits&, unsigned int, llvm::SimplifyQuery const&)
  -132,162,101    computeKnownBitsFromOperator(llvm::Operator const*, llvm::APInt const&, llvm::KnownBits&, unsigned int, llvm::SimplifyQuery const&) [clone
   124,686,235    computeKnownBitsFromOperator(llvm::Operator const*, llvm::APInt const&, llvm::KnownBits&, unsigned int, llvm::SimplifyQuery const&)
   114,060,111    llvm::LiveIntervalCalc::calculate(llvm::LiveInterval&, bool)
  -113,662,179    llvm::LiveIntervals::computeVirtRegs()
   104,218,878    llvm::PointerMayBeCaptured(llvm::Value const*, llvm::CaptureTracker*, unsigned int)
   -97,035,202    llvm::SelectionDAGISel::CodeGenAndEmitDAG()
   -90,098,002    llvm::AAResults::getModRefInfo(llvm::Instruction const*, std::optional<llvm::MemoryLocation> const&, llvm::AAQueryInfo&)
    89,433,445    llvm::RAGreedy::calculateRegionSplitCostAroundReg(unsigned short, llvm::AllocationOrder&, llvm::BlockFrequency&, unsigned int&, unsigned int&)
   -83,724,622    llvm::RAGreedy::calculateRegionSplitCost(llvm::LiveInterval const&, llvm::AllocationOrder&, llvm::BlockFrequency&, unsigned int&, bool)
    82,820,615    computeKnownBits(llvm::Value const*, llvm::APInt const&, llvm::KnownBits&, unsigned int, llvm::SimplifyQuery const&) [clone
   -72,563,818    llvm::ScheduleDAGSDNodes::BuildSchedGraph(llvm::AAResults*)
    71,100,555    llvm::SelectionDAG::Legalize()
   -70,774,808    std::back_insert_iterator<llvm::SmallVector<llvm::BasicBlock*, 8u> > std::copy<llvm::po_iterator<llvm::BasicBlock*, llvm::SmallPtrSet<llvm::BasicBlock*, 8u>, false, llvm::GraphTraits<llvm::BasicBlock*> >, std::back_insert_iterator<llvm::SmallVector<llvm::BasicBlock*, 8u> > >(llvm::po_iterator<llvm::BasicBlock*, llvm::SmallPtrSet<llvm::BasicBlo>
    68,499,576    llvm::ScheduleDAGSDNodes::AddSchedEdges()
   -67,376,856    (anonymous namespace)::TailRecursionEliminator::eliminate(llvm::Function&, llvm::TargetTransformInfo const*, llvm::AAResults*, llvm::OptimizationRemarkEmitter*, llvm::DomTreeUpdater&) [clone
    66,298,390    computePointerICmp(llvm::CmpInst::Predicate, llvm::Value*, llvm::Value*, llvm::SimplifyQuery const&)
    62,749,680    std::back_insert_iterator<llvm::SmallVector<llvm::BasicBlock*, 8u> > std::__copy_move_a2<false, llvm::po_iterator<llvm::BasicBlock*, llvm::SmallPtrSet<llvm::BasicBlock*, 8u>, false, llvm::GraphTraits<llvm::BasicBlock*> >, std::back_insert_iterator<llvm::SmallVector<llvm::BasicBlock*, 8u> > >(llvm::po_iterator<llvm::BasicBlock*, llvm::SmallPtrS>
   -62,208,865    simplifyICmpInst(unsigned int, llvm::Value*, llvm::Value*, llvm::SimplifyQuery const&, unsigned int) [clone
    59,398,553    llvm::SCCPInstVisitor::markUsersAsChanged(llvm::Value*)
   -58,896,104    llvm::RegAllocBase::allocatePhysRegs()
    57,899,944    llvm::RAGreedy::selectOrSplitImpl(llvm::LiveInterval const&, llvm::SmallVectorImpl<llvm::Register>&, llvm::SmallSet<llvm::Register, 16u, std::less<llvm::Register> >&, llvm::SmallVector<std::pair<llvm::LiveInterval const*, llvm::MCRegister>, 8u>&, unsigned int)

what the eff. we should probably look into this more, it’s super weird

I remember that sometimes binary/dynamic library size increases also increased icounts due to the dynamic linker doing more work. But based on CacheGrind, it looks like LLVM is actually doing more work, seems like it maybe iterates over more passes that were enabled by the amdgpu target?

The max-rss increases also look unexpected, and numerous enough to not be measurement noise. (Could memory allocation be in these ??? cg reports, sometimes it does this for me rather than finding jemalloc/malloc, probably some tests with local builds could be interesting with better debuginfo. That would also help with checking the cycles and wall time results, which seemingly aren’t super stable in these results.)

Does this need more time to bake maybe? @Mark-Simulacrum you’ve marked this as triaged because it’s less actionable on our side than in llvm, right?

hate to go "ooh, LLVM troubles, let's tell Nikita!" but uhhhh "weird LLVM perf" really does need the Vibe Sense of that kind of expertise, sooo cc @nikic

Adding the amdgpu target shouldn't make any additional passes run -- additional cost from registering additional passes etc is plausible though.

max-rss increasing with increasing code size is pretty common.